Fix Windows list dir handle leak #64461
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a handle leak on Windows when calling list_dir_begin() and forgetting to call list_dir_end(). For example, the code example in https://docs.godotengine.org/en/stable/classes/class_directory.html currently leaks the find handle every time it is called. This PR adds a call to list_dir_end() to the DirAccessWindows destructor, similar to other platform versions. Probably should be cherry-picked to 3.x, or does this need a separate PR for a fix this simple?